Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix slack msg failing on extensions workflows tests #12887

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix slack msg failing on extensions workflows tests #12887

merged 1 commit into from
Dec 16, 2024
+9 −3

Conversation

aalves08
Copy link
Member

Summary

Fixes #

Occurred changes and/or fixed issues

Fixes https://github.com/rancher/dashboard/actions/runs/12306968380/job/34350302524, https://github.com/rancher/dashboard/actions/runs/12307261565, https://github.com/rancher/dashboard/actions/runs/12307269246

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 self-assigned this Dec 13, 2024
@aalves08 aalves08 requested a review from jordojordo December 13, 2024 16:57
@aalves08 aalves08 merged commit 29cb65b into rancher:master Dec 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordojordo jordojordo jordojordo approved these changes

Assignees

@aalves08 aalves08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalves08 @jordojordo